Fix CREATE TABLE with DEFAULT function calls in parentheses #306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #300 - Support for
DEFAULT (now())and other function calls wrapped in parentheses in CREATE TABLE statements.Problem
The MySQL 8.0 syntax
DEFAULT (function())was failing because the translator only consumed a single token after the DEFAULT keyword. For expressions likeDEFAULT (now()), it would only capture the opening parenthesis(, causing the query translation to fail.Solution
Enhanced the DEFAULT clause handler in
WP_SQLite_Translatorto: